This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: RFC: PATCH to diagnostic.c:text_specifies_location


On 19 Mar 2003 21:12:30 +0100, Gabriel Dos Reis <gdr at integrable-solutions dot net> wrote:

> Jason Merrill <jason at redhat dot com> writes:
>
> [...]
>
> | The patch below causes us to ignore a location_t that specifies line 0;
> | instead we will just use the current file and line in the error message.
> | Do people think this is a good idea, or is it more useful to explicitly
> | tell the user that the declaration is a builtin?  I'm actually leaning a
> | bit towards the latter now.  The dg harness can handle messages at line 0.
>
> In my opinion, <internal>:0 makes much more sense than <internal>:19.  

Absolutely.  The choice is between <internal>:0 and foo.C:19.

Jason


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]