This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Fix PR optimization/8366 (Sparc)

From: Richard Henderson <rth at redhat dot com>
To: Eric Botcazou <ebotcazou at libertysurf dot fr>
Cc: gcc-patches at gcc dot gnu dot org
Date: Sat, 15 Mar 2003 16:30:33 -0800
Subject: Re: [PATCH] Fix PR optimization/8366 (Sparc)
References: <200303090911.50057.ebotcazou@libertysurf.fr> <200303150029.52811.ebotcazou@libertysurf.fr> <20030315004246.GA31480@redhat.com> <200303160053.51765.ebotcazou@libertysurf.fr>

On Sun, Mar 16, 2003 at 12:53:51AM +0100, Eric Botcazou wrote:
> 	* config/sparc/sparc.h: (SYMBOLIC_CONST): New.
> 	(GO_IF_LEGITIMATE_ADDRESS): Use it. Reject the form
> 	PIC+SYMBOLIC_CONST in other modes than Pmode.
> 	(GO_IF_MODE_DEPENDENT_ADDRESS): Use it. Mark
> 	the form PIC+SYMBOLIC_CONST as mode dependent.

This is ok, except for SYMBOLIC_CONST.  You might as well
call symbolic_operand directly all the time.

> If so, on which branch(es) are you willing to accept the fix?

All of them.

For mainline I'd prefer to see all of these pulled out of line,
but this is not a requirement for your patch.

r~

Follow-Ups:
- Re: [PATCH] Fix PR optimization/8366 (Sparc)
  - From: Eric Botcazou

References:
- [PATCH] Fix PR optimization/8366 (Sparc)
  - From: Eric Botcazou
- Re: [PATCH] Fix PR optimization/8366 (Sparc)
  - From: Eric Botcazou
- Re: [PATCH] Fix PR optimization/8366 (Sparc)
  - From: Richard Henderson
- Re: [PATCH] Fix PR optimization/8366 (Sparc)
  - From: Eric Botcazou

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]