This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: patch: disable string insns on ppc e500

From: Aldy Hernandez <aldy at quesejoda dot com>
To: David Edelsohn <dje at watson dot ibm dot com>
Cc: Richard Henderson <rth at redhat dot com>, Geoff Keating <geoffk at geoffk dot org>, gcc-patches at gcc dot gnu dot org
Date: Tue, 11 Mar 2003 15:27:49 -0800
Subject: Re: patch: disable string insns on ppc e500

Richard> You should be checking target_flags_explicit here, not target_flags.

The PowerPC port adds MASK_MULTIPLE and MASK_STRING to target_flags if optimizing for size, so target_flags is the right variable to test. This is not just disabling MASK_STRING set by the user, although the user also could set it.

Exactly.


	Aldy could add a test checking for E500 before enabling
MASK_STRING when optimizing for size, and separately disable it if not
explicitly set.  Or test both target_flags and target_flags_explicit.

Not exactly because the CPU is set in eabispe.h's SUBSUBTARGET_OVERRIDE_OPTIONS, which isn't defined until the code in question. My check has to come right after SUBSUBTARGET*, or the set of MASK_STRING has to come after SUBSUBTARGET*.

Aldy

References:
- Re: patch: disable string insns on ppc e500
  - From: David Edelsohn

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]