This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: Improve wrapup_globals_for_namespace in C++ front end




--On Sunday, March 02, 2003 08:07:43 PM -0800 Matt Austern <austern at apple dot com> wrote:

+  VARRAY_TREE_INIT (global_binding_level->static_decls,
+		    200,

I'm not keen on the weird magic constants, but I guess we can live with that for now. I don't really see much point in VARRAY constructors taking a length parameter, as there are basically two cases: the VARRAY doesn't ever grow much, in which case it only gets reallocated a few times, so it's no big deal, or it grows a lot, in which case the double-as-you-grow thing means that you don't do much work. In other words, initial size doesn't matter much.


Anyhow, the patch is fine; thanks.

--
Mark Mitchell                mark at codesourcery dot com
CodeSourcery, LLC            http://www.codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]