Re: [3.3] C++ PATCH: Reduce size of saved bindings.

[Gabriel Dos Reis <gdr at integrable-solutions dot net>]

Michael Matz <matz at suse dot de> writes:

| Hi Gabriel,
| 
| On 4 Mar 2003, Gabriel Dos Reis wrote:
| 
| >   This patch makes us be less wasteful.  It uses a straight datatype to
| > remember the bindings, reducing memory consuming.  Some days, when we
| > have better adequate data structures to capture name lookup machinery,
| > we may not even need to allocate so much memory. Or we may now take
| > advantage of this "typeful" datatype and manage a dedicated
| > cxx_saved_binding allocator possibly with a free-list.  To be explored
| > latter.
| 
| Hmm, I like performance improvements. 

This patch is not about performance improvement:  It is about fixing
compile-time performance regression.  

This patch appears isolated, but in reality it is is member of a
series of patches to fix compile-time performance regression.  The
reason I committed is that it does a single logical thing.  Having a
large patch that does many things does help nobody.

Compile-time performance is listed a release criteria.

| But is the improvement high enough
| to justify a patch for 3.3 (which should be in bug-fixing only mode right
| now IMHO)?

The net benefit of the series of patches to follow reduces the
excessive amount of time reported in name lookup phase.

-- Gaby