Re: c++ failures

[Aldy Hernandez <aldyh at redhat dot com>]

> These have nothing to do with me.  You've gotten fooled because Aldy
> checked in a patch with no cp/ChangeLog entry; the entry is in the
> gcc/ChangeLog:
>
>         * cp/parser.c (cp_parser_init_declarator): Call vector_opaque_p
>         target hook.
>         Include target.h.
>         (cp_parser_init_declarator): Fix typo in function comments.
>
> This patch is incorrect, and I can't find any mention of it in
> gcc-patches -- which doesn't mean it wasn't there, just that I can't
> find it.  Who approved this patch?

Moi?  Of course, I got approval.  I just forgot to commit the 
cp/ChangeLog ;-).
rth approved the patch.  For that matter, I believe you were CCed in 
the discussion :).  Search for the thread entitled "disallow 
initializing certain aggregates".

> Aldy, would you please revert this patch?

No problem.  I am committing the patch below.

> The check you are trying to add should probably go in
> decl.c:check_initializer instead.

I will submit a follow up patch shortly taking this approach.

BTW, did my patch cause problems?  I can't see how.

Aldy

2003-02-28  Aldy Hernandez  <aldyh at redhat dot com>

	* parser.c (cp_parser_init_declarator): Revert opaque
	vector_opaque_p change.
	Do not include target.h.

Index: parser.c
===================================================================
RCS file: /cvs/gcc/gcc/gcc/cp/parser.c,v
retrieving revision 1.47
diff -c -p -r1.47 parser.c
*** parser.c	25 Feb 2003 17:06:41 -0000	1.47
--- parser.c	1 Mar 2003 01:07:16 -0000
***************
*** 34,40 ****
  #include "diagnostic.h"
  #include "toplev.h"
  #include "output.h"
- #include "target.h"

  
  /* The lexer.  */
--- 34,39 ----
*************** cp_parser_init_declarator (cp_parser* pa
*** 9703,9715 ****

    /* Parse the initializer.  */
    if (is_initialized)
!     {
!       if ((*targetm.vector_opaque_p) (TREE_TYPE (decl)))
! 	cp_parser_error (parser, "opaque vector types cannot be 
initialized");
!
!       initializer = cp_parser_initializer (parser,
! 					   &is_parenthesized_init);
!     }
    else
      {
        initializer = NULL_TREE;
--- 9702,9708 ----

    /* Parse the initializer.  */
    if (is_initialized)
!     initializer = cp_parser_initializer (parser, 
&is_parenthesized_init);
    else
      {
        initializer = NULL_TREE;