This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Contribution: Support for Cirrus Maverick EP9312 chip
- From: Nick Clifton <nickc at redhat dot com>
- To: Richard dot Earnshaw at arm dot com
- Cc: gcc-patches at gcc dot gnu dot org
- Date: 28 Feb 2003 14:51:03 +0000
- Subject: Re: Contribution: Support for Cirrus Maverick EP9312 chip
- References: <200302281018.h1SAIb920341@pc960.cambridge.arm.com>
Hi Richard,
> (note_invalid_constants): Change from a void function to bool.
> Add an extra parameter, saying whether the fixups should be
> pushed. Return true if fixups are needed.
>
> This introduces a warning regression. You can't have a "bool" parameter
> in K&R compatible functions, since bool must be promoted when prototypes
> are not used. The parameter needs to be "int".
OK - fixed thusly.
Cheers
Nick
2003-02-28 Nick Clifton <nickc at redhat dot com>
* config/arm/arm.c (note_invalid_constants): Change parameter type
from bool to int.
Index: gcc/config/arm/arm.c
===================================================================
RCS file: /cvs/gcc/gcc/gcc/config/arm/arm.c,v
retrieving revision 1.262
diff -c -3 -p -w -r1.262 arm.c
*** gcc/config/arm/arm.c 26 Feb 2003 11:26:34 -0000 1.262
--- gcc/config/arm/arm.c 28 Feb 2003 14:47:03 -0000
*************** static int arm_barrier_cost PARAMS ((r
*** 113,119 ****
static Mfix * create_fix_barrier PARAMS ((Mfix *, Hint));
static void push_minipool_barrier PARAMS ((rtx, Hint));
static void push_minipool_fix PARAMS ((rtx, Hint, rtx *, Mmode, rtx));
! static bool note_invalid_constants PARAMS ((rtx, Hint, bool));
static int current_file_function_operand PARAMS ((rtx));
static Ulong arm_compute_save_reg0_reg12_mask PARAMS ((void));
static Ulong arm_compute_save_reg_mask PARAMS ((void));
--- 113,119 ----
static Mfix * create_fix_barrier PARAMS ((Mfix *, Hint));
static void push_minipool_barrier PARAMS ((rtx, Hint));
static void push_minipool_fix PARAMS ((rtx, Hint, rtx *, Mmode, rtx));
! static bool note_invalid_constants PARAMS ((rtx, Hint, int));
static int current_file_function_operand PARAMS ((rtx));
static Ulong arm_compute_save_reg0_reg12_mask PARAMS ((void));
static Ulong arm_compute_save_reg_mask PARAMS ((void));
*************** static bool
*** 6923,6929 ****
note_invalid_constants (insn, address, do_pushes)
rtx insn;
HOST_WIDE_INT address;
! bool do_pushes;
{
bool result = false;
int opno;
--- 6923,6929 ----
note_invalid_constants (insn, address, do_pushes)
rtx insn;
HOST_WIDE_INT address;
! int do_pushes;
{
bool result = false;
int opno;