This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch] libiberty/physmem support for w32


 > From: =?iso-8859-1?q?Danny=20Smith?= <danny_r_smith_2001 at yahoo dot co dot nz>
 > 
 > Hello
 > 
 > This adds physmem support for _WIN32. Note that cygwin doesn't define
 > _WIN32 by default.  However, cygwin doesn't need this because it has
 >  working sysconf.
 > 
 > What configury magic do I need to attack, or is the _WIN32 condition
 > sufficient?
 >   
 > libiberty/ChangeLog
 > 
 > 2003-02-24  Danny Smith  <dannysmith at users dot source dot forge dot net>
 > 
 > 	* physmem.c (physmem_total): Add _WIN32 support.
 > 	(physmem_available): Likewise.

We rely on _WIN32 in a few other places in libiberty, so I think it's
ok to do so here.  I.e. no separate autoconf magic necessary.  I'm not
sure what you meant by "cygwin doesn't define _WIN32 by default".
When you say "by default" are there some cases or conditions where
cygwin will define _WIN32?  If so, perhaps we need to add !__CYGWIN__ ?

Perhaps if someone will test on cygwin and/or comment on this question
we can be more sure.  With Zack's objection removed, I've checked it
in for now and I'll keep an eye out for any problems.

Thanks for your contribution.

		--Kaveh
--
Kaveh R. Ghazi			ghazi at caip dot rutgers dot edu


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]