This is the mail archive of the
mailing list for the GCC project.
Re: [Patch] libiberty/physmem support for w32
"Kaveh R. Ghazi" <ghazi at caip dot rutgers dot edu> writes:
> > Please factor common code out to a helper routine.
> Zack - I looked and couldn't figure out how exactly to factor out any
> code that didn't make things especially ugly. The only thing that
> comes out easily is the one function call to
> The rest of the code, because it uses different structs and members
> ends up being unique. Perhaps I'm missing something, if so please
> help me understand what it is. Otherwise I'd like to consider the
> code as supplied.
I stared at this a bunch and I think you're right, there isn't much we
can do here. It's annoying, because this isn't just a Win32 problem,
*all* the platform blocks are
... several screens below ...
but not quite
But yeah, don't let me grousing stop you.