This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: fix for crash with profile feedback


	I just tried to use -fbranch-probabilities and noticed that it no
longer generates multiple sections.  When I investigated, I tracked it
down to the patch

	* predict.c (choose_function_section): Avoid choice for linkonce
	functions.

The logic in the statement

	|| !DECL_ONE_ONLY (current_function_decl))

seems reversed and contradicts the comment.  I think the negation (!) is
incorrect.  As it currently is written, no function section is set if
DECL_ONE_ONLY is *unset*.  DECL_ONE_ONLY set means linkonce, so linkonce
text sections *are* overridden.

Thanks, David


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]