This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix mips-tfile.c compilation warnings


 > The following patch fixes several compilation warnings in mips-tfile.c
 > that occur during bootstrap of alphaev67-dec-osf5.1 causing it to fail
 > with the recent -Werror changes.  Several of these warnings should
 > also occur on mips-sgi-irix6.5, so I'm guessing this patch should also
 > help the bootstrap there.

No, ironically mips-irix6 doesn't use "mips"-tfile whereas apparently
alpha does.  I've never figured out why this is, but I am curious. :-)


 > In the patch below I've decided to make file_offset and
 > max_file_offset "unsigned long" and cast all comparisons againt them
 > to that type.  This avoids the system-dependent signedness of off_t
 > and the fields of FDR, and not introduce new warnings on any platform
 > [fingers crossed].
 > 
 > The following patch has been tested during a clean bootstrap of
 > alphaev67-dec-osf5.1, where these changes silence the warnings and
 > allow the bootstrap to proceed past this failure.  Unfortunately, the
 > bootstrap fails yet again even later.  Hopefully the changes are
 > almost "obvious", so the lack of regression testing shouldn't be too
 > much of a concern.

If -Werror is the only thing stopping your bootstrap, you can test
your patch by configuring with --disable-werror, and test with and
without the patch to see if something breaks.

		--Kaveh
--
Kaveh R. Ghazi			ghazi@caip.rutgers.edu


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]