This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Avoid DT_TEXTREL libgcj.so on s390*


Hello Jakub,

>libgcj has one .text relocation (against ffi_closure_helper_SYSV).
>Either it can be made .hidden (the attribute will be ignored by
>older GCCs), or sysv.S should call ffi_closure_helper_SYSV through
>PLT.

Doing PLT calls is a bit awkward as the ABI requires the GOT
register to be set up before calling a PLT stub.  Also, the
code should work in the non-PIC case as well.  Thus I agree
that making the helper function hidden is the best solution.

>The __attribute__ could be guarded with
>#if __GNUC__ > 3 || (__GNUC__ == 3 && __GNUC_MINOR__ > 2)
>if libffi is meant to be built by non-GCC compilers.

I guess we should do that.  With this addition, your patch is OK;
if you've tested your change, could you please commit it?
Thanks!



 Mit freundlichen Gruessen / Best Regards

 Ulrich Weigand

 --
   Dr. Ulrich Weigand
   Linux for S/390 Design & Development
   IBM Deutschland Entwicklung GmbH, Schoenaicher Str. 220, 71032
 Boeblingen
   Phone: +49-7031/16-3727   ---   Email: Ulrich.Weigand@de.ibm.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]