This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch] gcse.c: Fix the header ordering.

From: Zack Weinberg <zack at codesourcery dot com>
To: Kazu Hirata <kazu at cs dot umass dot edu>
Cc: graham dot stott at btinternet dot com, gcc-patches at gcc dot gnu dot org, roger at www dot eyesopen dot com
Date: Fri, 31 Jan 2003 14:46:20 -0800
Subject: Re: [patch] gcse.c: Fix the header ordering.
References: <20030131.125143.26273126.kazu@cs.umass.edu><3E3AC763.4000309@btinternet.com><20030131.151750.68036329.kazu@cs.umass.edu>

Kazu Hirata <kazu@cs.umass.edu> writes:

>> I think rtl.h should include insn-config.
>> 
>> Note in the not to distant past such nested included were discouraged but
>> it would appear that that position has changed because grepping for
>> "#include" in *.h files within the gcc directory gets quite a few hits.
>
> Discouraged for simplicity?  Or for a little more specific reason?
>
> I just put insn-config.h before rtl.h in combine.c, the generated code
> seems to get slightly better.  (That is, CC0_P in combine.c is now
> triggered.)

rtl.h is supposed to be machine independent - that is, it should have
no dependencies on tm.h or any insn-*.h.  The CC0_P macro needs to be
moved to a more appropriate location.

zw

References:
- [patch] gcse.c: Fix the header ordering.
  - From: Kazu Hirata
- Re: [patch] gcse.c: Fix the header ordering.
  - From: Graham Stott
- Re: [patch] gcse.c: Fix the header ordering.
  - From: Kazu Hirata

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]