This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: gcc/gcc/cp ChangeLog dump.c
- From: Alexandre Oliva <aoliva at redhat dot com>
- To: Gabriel Dos Reis <gdr at integrable-solutions dot net>
- Cc: Nathanael Nerode <neroden at twcny dot rr dot com>, gcc-patches at gcc dot gnu dot org
- Date: 25 Jan 2003 01:16:09 -0200
- Subject: Re: gcc/gcc/cp ChangeLog dump.c
- Organization: GCC Team, Red Hat
- References: <3E31920A.1060708@twcny.rr.com><m3adhq1gsw.fsf@uniton.integrable-solutions.net>
On Jan 24, 2003, Gabriel Dos Reis <gdr@integrable-solutions.net> wrote:
> | in which case the boolification change has *nothing* to
> | do with ANSIfication? I'm confused by what you're saying.
> I believe there is a fundamental misunderstanding here. The exercise
> of converting the sources isn't to have you or others to act like
> kr2ansi.
Still, I agree with Nathan that removing PARAMS is a no-brainer
change, akin to fixing typos in comments or adjusting indentation,
that can go in without explicit approval or careful reviews, whereas
modifying the return type of functions does require additional review
and, being an unrelated change, should better be done as a separate
patch, at the very least, to make sure that the functional change
doesn't get lost in the noise.
--
Alexandre Oliva Enjoy Guarana', see http://www.ic.unicamp.br/~oliva/
Red Hat GCC Developer aoliva@{redhat.com, gcc.gnu.org}
CS PhD student at IC-Unicamp oliva@{lsd.ic.unicamp.br, gnu.org}
Free Software Evangelist Professional serial bug killer