This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: RFC/RFT: split up pexecute.c
- From: DJ Delorie <dj at redhat dot com>
- To: zack at codesourcery dot com
- Cc: gcc-patches at gcc dot gnu dot org, binutils at sources dot redhat dot com
- Date: Wed, 22 Jan 2003 13:29:37 -0500
- Subject: Re: RFC/RFT: split up pexecute.c
- References: <87hec18xmi.fsf@egil.codesourcery.com>
> It simply breaks up pexecute.c into seven variant files: cygwin,
> djgpp, mpw, msdos, os2, unix, win32. pexecute.c just #includes
> whichever one is relevant.
I have no fundamental issue with breaking this file up, but I do have
two concerns:
> * pexecute.c: Split up; meat moved to...
> * pexecute-cygwin.c, pexecute-djgpp.c, pexecute-mpw.c,
> pexecute-msdos.c, pexecute-os2.c, pexecute-unix.c,
> pexecute-win32.c: ... these new files.
1. These file names are no 8.3 compatible. To be usable on all DJGPP
systems, names must be unique within the first 8 characters of the
basename. Perhaps "pex-<system>.c" would be ok?
2. I would rather have configure choose the appropriate files to
include in the build, than to have one .c file include another .c
file. I know this is a little more work, but some debug formats
don't like executable code in #included files.