This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Fix testsuite for inlining


> > On Tue, Jan 21, 2003 at 08:28:37PM +0100, Jan Hubicka wrote:
> > > for string/stdio my code actually overwrote builtins by the actual
> > > functions so even with noinlining they didn't simplify.
> > 
> > This would be a bug in _your_ code, not the test case.
> > 
> > Don't apply these changes.
> I've already done so, but I believe they are not bogus - the testcase
> fails without noinlines even after fixing the code.  I just wanted to
> menion I possibly left in some extra noinlines in some of testcases (I
> reviewed patch for these but perhaps I didn't caught all of them), but
> all testcases still needs at least some noinlines.  For instance testcase reads:

Thinking about it, alternative behaviours can be:
1) make compiler to only forward inline when function overwrites builtin
   (100% compatible with current code)
2) make compiler to never inline when function overwrite builtin
   (consistent, but will break glibc and kernel headers at least)

What I am doing right now is to overwrite builtin by function only when
function will inline that is also too consistent.  In case 1) or 2)
is way to go, I can revert the *-opt.c part of the patch.

Honza


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]