This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Fix SCHED_GROUP_P ICEs on v850

From: Vladimir Makarov <vmakarov at redhat dot com>
To: Graham Stott <graham dot stott at btinternet dot com>
Cc: Roger Sayle <roger at www dot eyesopen dot com>, gcc-patches at gcc dot gnu dot org
Date: Mon, 20 Jan 2003 14:38:59 -0500
Subject: Re: [PATCH] Fix SCHED_GROUP_P ICEs on v850
References: <Pine.LNX.4.44.0301190809100.30567-100000@www.eyesopen.com> <3E2AEFC3.FFB2C315@redhat.com> <3E2B2C7F.9030401@btinternet.com>

Graham Stott wrote:
> 
> Vlad,
> 
> >
> >   I think there is no big harm from the patch.  We can only lose a note (it
> > might be serious or not, at least it is less serious than the ice).  The
> > scheduler removes notes before scheduling a block.  There should be no notes
> > at this stage but they are present.  So the bug is in something else.
> > I suspect that when we move insn from one block to another, the block being
> > scheduled has no notes but the block from which the insn is moved has
> > notes.  This is a design flaw.  It can not be easy solved.
> >
> > Vlad
> >
> >
> >
> 
> It's NOTE_INSN_DELETED notes that are tripping up the abort.

In this case, this patch is absolutely safe.  But there is a tiny
probability of that an important note can be lost.

References:
- [PATCH] Fix SCHED_GROUP_P ICEs on v850
  - From: Roger Sayle
- Re: [PATCH] Fix SCHED_GROUP_P ICEs on v850
  - From: Vladimir N. Makarov
- Re: [PATCH] Fix SCHED_GROUP_P ICEs on v850
  - From: Graham Stott

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]