This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Patch for format bug in i386.c (cygwin)
- From: Christopher Faylor <cgf at redhat dot com>
- To: "Kaveh R. Ghazi" <ghazi at caip dot rutgers dot edu>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Fri, 17 Jan 2003 01:51:22 -0500
- Subject: Re: Patch for format bug in i386.c (cygwin)
- References: <200301161612.LAA16426@caip.rutgers.edu>
On Thu, Jan 16, 2003 at 11:12:55AM -0500, Kaveh R. Ghazi wrote:
>My warnings sweep came across this actual bug in i386.c on the cygwin
>cross-compile. Since I don't speak x86 assembly, I'd like this one
>reviewed.
>
>Tested by cross-compiling cc1 to i686-pc-cygwin.
>Ok to install?
It looks right to me.
cgf
>2003-01-16 Kaveh R. Ghazi <ghazi@caip.rutgers.edu>
>
> * i386.c (x86_function_profiler): Fix format specifier.
>
>diff -rup orig/egcc-CVS20030114/gcc/config/i386/i386.c egcc-CVS20030114/gcc/config/i386/i386.c
>--- orig/egcc-CVS20030114/gcc/config/i386/i386.c 2003-01-11 07:00:29.000000000 -0500
>+++ egcc-CVS20030114/gcc/config/i386/i386.c 2003-01-15 21:44:25.810309000 -0500
>@@ -14823,7 +14823,7 @@ x86_function_profiler (file, labelno)
> else
> {
> #ifndef NO_PROFILE_COUNTERS
>- fprintf (file, "\tmovl\t$%sP%d,%%$s\n", LPREFIX, labelno,
>+ fprintf (file, "\tmovl\t$%sP%d,%%$%s\n", LPREFIX, labelno,
> PROFILE_COUNT_REGISTER);
> #endif
> fprintf (file, "\tcall\t%s\n", MCOUNT_NAME);