This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [tree-ssa] get_lineno and get_filename problem


On Thu, 16 Jan 2003, Diego Novillo wrote:

> Thanks.  The patch seems fine, but before you can commit it:

 Me?? I though that by posting in the patch list you would apply the patch
to the tree-ssa branch. If I do the commit to the cvs, I need write
permition, isn't it?.

> - Do you have an FSF copyright assignment?  For this patch it may

 Can you send me the forms?

> - You need to add ChangeLog entries and format the code according
>   to the guidelines in http://gcc.gnu.org/contribute.html.

 Is something like that fine?

2003-01-16  Jose Renau <renau@uiuc.edu>

	* tree-flow-inline.h (get_lineno, get_filename): Check locus 
	existence

 Format related, I noticed that I used if(...), Is it fine? or do I use 
if (...) ? Did you notice anything else?

-- 
-------------------------------------------------------------------
 Jose Renau       | "The difference between genius and stupidity 
   renau@uiuc.edu | is that genius has its limits" -Albert Einstein
-------------------------------------------------------------------



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]