This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Merging PCH to mainline
- From: David Edelsohn <dje at watson dot ibm dot com>
- To: Geoff Keating <geoffk at geoffk dot org>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Fri, 10 Jan 2003 21:51:44 -0500
- Subject: Re: Merging PCH to mainline
I have tracked down another PCH-related rs6000 failure and I can
fix it by adding GTY(()), but I would have thought that the logic is
correct now and adding PCH machinery wrong.
The bug is when compiling with PCH, GCC emits the assembler extern
declarations of the AIX common-mode functions for each function compiled
instead of once with the first function in the file. Emitting declaration
is controlled by a static variable common_mode_defined in rs6000.c.
Adding GTY(()) to the declaration produces correct behavior, but this
should not be information associated with PCH, so I do not understand why
restoring its state should be correct. It seems that common_mode_defined
would need to be reset for each function for things to be working
incorrectly now.
David