This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] powerpc64: fix g++ -msoft-float
- From: Janis Johnson <janis187 at us dot ibm dot com>
- To: David Edelsohn <dje at watson dot ibm dot com>
- Cc: Janis Johnson <janis187 at us dot ibm dot com>, gcc-patches at gcc dot gnu dot org
- Date: Fri, 10 Jan 2003 13:37:41 -0800
- Subject: Re: [PATCH] powerpc64: fix g++ -msoft-float
- References: <20030110130908.B2385@us.ibm.com> <200301102126.QAA05678@makai.watson.ibm.com>
On Fri, Jan 10, 2003 at 04:26:48PM -0500, David Edelsohn wrote:
> 2003-01-10 Janis Johnson <janis187@us.ibm.com>
>
> * config/rs6000/rs6000.h: MIN_UNITS_PER_WORD is always 4.
>
> This patch is *not* correct and that change *must not* be reverted.
> MIN_UNITS_PER_WORD needs to be set for libgcc2.a to include TImode
> support in 64-bit mode.
>
> Did you look at the original patch and discussion?
>
> http://gcc.gnu.org/ml/gcc-patches/2002-08/msg01587.html
Well, of course I wouldn't revert it without your approval.
I had looked at that message, but didn't see why this change was needed,
and didn't see that it had actually been tested on powerpc64. There are
no test suite changes with this patch; what is expected to be different?
Where is TImode support used, if it's not exercised by the testsuite?
Janis