This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Patch: fix regression in PPC sibcalls
- From: David Edelsohn <dje at watson dot ibm dot com>
- To: Daniel Jacobowitz <drow at mvista dot com>
- Cc: gcc-patches at gcc dot gnu dot org, Dale Johannesen <dalej at apple dot com>
- Date: Fri, 03 Jan 2003 20:14:06 -0500
- Subject: Re: Patch: fix regression in PPC sibcalls
- References: <20030103202615.GA25037@nevyn.them.org>
Dale> Perhaps I should just request that J"orn Rennecke's patch above be
Dale> reverted. If this doesn't get approved I'll do that, I guess.
Daniel> No. As I understand it, it breaks sibcalls on PowerPC, which were
Daniel> added after the patch itself by several months. Reverting it will
Daniel> definitely break sibcalls on SH, which were there beforehand.
If J"orn's patch was flawed, then it was flawed, regardless that
it fixes sibcalls on SH. A broken patch does not need to be retained
because it fixes a bug incorrectly or incompletely. This should be fixed
correctly on all targets, but *neither* target has a preferred position to
trump the other.
David