This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PATCH: improve vtable emission
- From: Matt Austern <austern at apple dot com>
- To: Mark Mitchell <mark at codesourcery dot com>
- Cc: Nathan Sidwell <nathan at codesourcery dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Date: Thu, 2 Jan 2003 21:18:52 -0800
- Subject: Re: PATCH: improve vtable emission
On Thursday, January 2, 2003, at 06:09 PM, Mark Mitchell wrote:
--On Thursday, January 02, 2003 01:40:35 PM -0800 Matt Austern
<austern@apple.com> wrote:
+#if 0
+ /* This would be nice, but we didn't think of it in time. */
+ || DECL_DESTRUCTOR_P (method)
+#endif
Remove this; as Geoff said, we don't believe in #if 0'd code.
I always assumed you were the one who put that #if 0 section
in! But, of course, I'll be happy to remove it. As you say,
it'll be cleaner with it gone.
On a slightly related subject... Removing the special-casing for
a key function that's declared inline out of the class is indeed
correct according to the ABI document, but it is a change in our
compiler's behavior. I think it's correct to make this change
(it fixes a bug, and I can't think of any way it'll cause a
problem), but I wanted to make sure people realized it is a change.
I'll fix the style issues and check it in.
--Matt