This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
[3.4-BIB]fixincludes failure on solaris
- From: Bruce Korb <bkorb at pacbell dot net>
- To: Jan Hubicka <jh at suse dot cz>, gcc <gcc at gcc dot gnu dot org>, GCC-Patches <gcc-patches at gcc dot gnu dot org>, Zack Weinberg <zack at codesourcery dot com>
- Date: Mon, 16 Dec 2002 09:41:22 -0800
- Subject: [3.4-BIB]fixincludes failure on solaris
- Organization: Home
> Hi,
> server.c requires SIGKILL to be defined that is defined by signal.h
> not included by system.h. That fails on solaris.
> What is the proper fix? SHould I include signal.h in system.h and add
> configure bits for that one?
fixincl.c already includes it. It should move to fixlib.h
to give all the modules access to it. We should have noticed
this several years ago.
Commit to BIB? Or mainline? Wait for Zack?
It's pretty "obvious" and should cause no conflicts.
$ cvs diff .
cvs server: Diffing .
Index: fixincl.c
===================================================================
RCS file: /cvs/gcc/gcc/gcc/fixinc/fixincl.c,v
retrieving revision 1.57
diff -u -p -r1.57 fixincl.c
--- fixincl.c 4 Dec 2001 23:29:42 -0000 1.57
+++ fixincl.c 16 Dec 2002 17:27:16 -0000
@@ -28,7 +28,6 @@ Boston, MA 02111-1307, USA. */
#define BAD_ADDR ((void*)-1)
#endif
-#include <signal.h>
#if ! defined( SIGCHLD ) && defined( SIGCLD )
# define SIGCHLD SIGCLD
#endif
Index: fixlib.h
===================================================================
RCS file: /cvs/gcc/gcc/gcc/fixinc/fixlib.h,v
retrieving revision 1.24.30.1
diff -u -p -r1.24.30.1 fixlib.h
--- fixlib.h 1 Dec 2002 05:43:03 -0000 1.24.30.1
+++ fixlib.h 16 Dec 2002 17:27:16 -0000
@@ -29,6 +29,7 @@ Boston, MA 02111-1307, USA. */
#include "system.h"
#include "coretypes.h"
#include "tm.h"
+#include <signal.h>
#include "gnu-regex.h"
#include "machname.h"