Re: [Configure patch] Issue error if bison not found

[Craig Rodrigues <rodrigc at attbi dot com>]

On Thu, Nov 28, 2002 at 12:04:02PM +0000, Joseph S. Myers wrote:
> On Thu, 28 Nov 2002, Craig Rodrigues wrote:
> 
> > The result is that when trying to use bison, "missing bison"
> > is invoked, and a more useful WARNING message is printed out,
> > rather than invoking "false" with bison's arguments.
> > I did the same for flex.
> > 
> > Is it OK for the mainline?
> 
> For mainline, this sort of thing is bad if the build then *doesn't* fail,
> since people may end up building with inconsistent .c and .y versions,

The build *does* fail, just like it did before, *and* the WARNING message 
is printed out.

So, is this patch OK for mainline?



gcc -c    -g -DIN_GCC  -W -Wall -Wwrite-strings -Wstrict-prototypes -Wmissing-prototypes -Wtraditional -pedantic -Wno-long-long -fno-common  -DHAVE_CONFIG_H -DGENERATOR_FILE    -I. -I. -I/home/rodrigc/testgcc/gcc/gcc -I/home/rodrigc/testgcc/gcc/gcc/.  -I/home/rodrigc/testgcc/gcc/gcc/config -I/home/rodrigc/testgcc/gcc/gcc/../include  /home/rodrigc/testgcc/gcc/gcc/gengtype.c -o gengtype.o
cd /home/rodrigc/testgcc/gcc/gcc &&  flex  -t -o/home/rodrigc/testgcc/gcc/gcc/gengtype-lex.c gengtype-lex.l |  sed 's/^\(char msg\[\];\)/yyconst \1/' > g-$$ ;  if test $? -eq 0 ; then  mv -f g-$$ gengtype-lex.c ;  else  rm -f g-$$.* ;  false ;  fi
(cd /home/rodrigc/testgcc/gcc/gcc &&  /usr/local/bin/bash /home/rodrigc/testgcc/gcc/gcc/../missing bison  -d -o gengtype-yacc.c gengtype-yacc.y ||  ( rm -f /home/rodrigc/testgcc/gcc/gcc/gengtype-yacc.c && false ) )
WARNING: `bison' is missing on your system.  You should only need it if
         you modified a `.y' file.  You may need the `Bison' package
         in order for those modifications to take effect.  You can get
         `Bison' from any GNU archive site.
gcc -c    -g -DIN_GCC  -W -Wall -Wwrite-strings -Wstrict-prototypes -Wmissing-prototypes -Wtraditional -pedantic -Wno-long-long -fno-common  -DHAVE_CONFIG_H -DGENERATOR_FILE    -I. -I. -I/home/rodrigc/testgcc/gcc/gcc -I/home/rodrigc/testgcc/gcc/gcc/.  -I/home/rodrigc/testgcc/gcc/gcc/config -I/home/rodrigc/testgcc/gcc/gcc/../include  /home/rodrigc/testgcc/gcc/gcc/gengtype-lex.c -o gengtype-lex.o
gengtype-lex.l:29:27: gengtype-yacc.h: No such file or directory
gengtype-lex.l: In function `yylex':
gengtype-lex.l:173: `yylval' undeclared (first use in this function)
gengtype-lex.l:173: (Each undeclared identifier is reported only once
gengtype-lex.l:173: for each function it appears in.)
gengtype-lex.l:176: `ENT_TYPEDEF_STRUCT' undeclared (first use in this function)
gengtype-lex.l:176: `ENT_STRUCT' undeclared (first use in this function)
gengtype-lex.l:182: `ENT_EXTERNSTATIC' undeclared (first use in this function)
gengtype-lex.l:188: `ENT_YACCUNION' undeclared (first use in this function)
gengtype-lex.l:201: `GTY_TOKEN' undeclared (first use in this function)
gengtype-lex.l:202: `UNION' undeclared (first use in this function)
gengtype-lex.l:203: `STRUCT' undeclared (first use in this function)
gengtype-lex.l:204: `ENUM' undeclared (first use in this function)
gengtype-lex.l:205: `ALIAS' undeclared (first use in this function)
gengtype-lex.l:206: `NUM' undeclared (first use in this function)
gengtype-lex.l:209: `PARAM_IS' undeclared (first use in this function)
gengtype-lex.l:221: `SCALAR' undeclared (first use in this function)
gengtype-lex.l:226: `ID' undeclared (first use in this function)
gengtype-lex.l:231: `STRING' undeclared (first use in this function)
gengtype-lex.l:235: `ARRAY' undeclared (first use in this function)
gengtype-lex.l:239: `PERCENT_ID' undeclared (first use in this function)
gengtype-lex.l:243: `CHAR' undeclared (first use in this function)
gengtype-lex.l:259: `PERCENTPERCENT' undeclared (first use in this function)
*** Error code 1

Stop in /usr/home/rodrigc/testgcc/build/gcc.
*** Error code 1

Stop in /usr/home/rodrigc/testgcc/build/gcc.
*** Error code 1

Stop in /usr/home/rodrigc/testgcc/build/gcc.
*** Error code 1

Stop in /usr/home/rodrigc/testgcc/build.



-- 
Craig Rodrigues        
http://www.gis.net/~craigr    
rodrigc@attbi.com