This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
[v3] Replacing string += "x" by 'x'
- From: Paolo Carlini <pcarlini at unitus dot it>
- To: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Cc: Wolfgang Bangerth <bangerth at ticam dot utexas dot edu>
- Date: Mon, 25 Nov 2002 20:08:27 +0100
- Subject: [v3] Replacing string += "x" by 'x'
Hi,
tested x86-linux, approved by Benjamin and myself.
Ciao, Paolo.
///////////
2002-11-25 Wolfgang Bangerth <bangerth@ticam.utexas.edu>
* include/std/std_complex.h
(operator<<(basic_ostream&, const complex&)): Prefer 'x'
to "x" for efficiency sake.
* src/locale.cc (locale::locale(const char*)): Ditto.
diff -urN libstdc++-v3-orig/include/std/std_complex.h libstdc++-v3/include/std/std_complex.h
--- libstdc++-v3-orig/include/std/std_complex.h 2002-01-28 23:13:10.000000000 +0100
+++ libstdc++-v3/include/std/std_complex.h 2002-11-25 19:32:24.000000000 +0100
@@ -390,7 +390,7 @@
__s.flags(__os.flags());
__s.imbue(__os.getloc());
__s.precision(__os.precision());
- __s << '(' << __x.real() << "," << __x.imag() << ')';
+ __s << '(' << __x.real() << ',' << __x.imag() << ')';
return __os << __s.str();
}
diff -urN libstdc++-v3-orig/src/locale.cc libstdc++-v3/src/locale.cc
--- libstdc++-v3-orig/src/locale.cc 2002-11-24 19:32:33.000000000 +0100
+++ libstdc++-v3/src/locale.cc 2002-11-25 19:30:40.000000000 +0100
@@ -235,14 +235,14 @@
for (size_t __j = 0; __j < __i; ++__j)
{
__str += _S_categories[__j];
- __str += "=";
+ __str += '=';
__str += __res;
- __str += ";";
+ __str += ';';
}
__str += _S_categories[__i];
- __str += "=";
+ __str += '=';
__str += __env;
- __str += ";";
+ __str += ';';
__i++;
for (; __i < _S_categories_size
+ _S_extra_categories_size; ++__i)
@@ -251,9 +251,9 @@
if (!__env || strcmp(__env, "") == 0)
{
__str += _S_categories[__i];
- __str += "=";
+ __str += '=';
__str += __res;
- __str += ";";
+ __str += ';';
}
else if (strcmp(__env, "C") == 0
|| strcmp(__env, "POSIX") == 0)
@@ -264,9 +264,9 @@
else
{
__str += _S_categories[__i];
- __str += "=";
+ __str += '=';
__str += __env;
- __str += ";";
+ __str += ';';
}
}
__str.erase(__str.end() - 1);
@@ -347,15 +347,15 @@
else
{
__ret += _S_categories[0];
- __ret += "=";
+ __ret += '=';
__ret += _M_impl->_M_names[0];
for (size_t __i = 1;
__i < _S_categories_size + _S_extra_categories_size;
++__i)
{
- __ret += ";";
+ __ret += ';';
__ret += _S_categories[__i];
- __ret += "=";
+ __ret += '=';
__ret += _M_impl->_M_names[__i];
}
}