This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Patch: rs6000-specific ICE
- From: David Edelsohn <dje at watson dot ibm dot com>
- To: Dale Johannesen <dalej at apple dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Fri, 18 Oct 2002 16:17:37 -0400
- Subject: Re: Patch: rs6000-specific ICE
- References: <95503E14-E2C5-11D6-8B65-000393D76DAA@apple.com>
>>>>> Dale Johannesen writes:
> It assumes that for any branch_comparison_operator,
> either it or its reversal qualifies as a
> branch_positive_comparison_operator.
> This is not the case for floating LE, for example.
Isn't this statement too general? That assumption is correct as
long as flag_unsafe_math_optimizations is not enabled. The problem arises
if unordered condition code appears because unordered gets flipped along
with the comparison.
Is the new test too strong? Should it only restrict the test if
flag_unsafe_math_optimizations is enabled?
Also, isn't the "&& 1" in the splitter unnecessary?
David