This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Patch: fix warnings regression in loop.c
- From: Geoff Keating <geoffk at geoffk dot org>
- To: "Kaveh R. Ghazi" <ghazi at caip dot rutgers dot edu>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: 09 Oct 2002 12:31:00 -0700
- Subject: Re: Patch: fix warnings regression in loop.c
- References: <200210091801.OAA25234@caip.rutgers.edu>
"Kaveh R. Ghazi" <ghazi@caip.rutgers.edu> writes:
> Fixes:
> > loop.c:916: warning: comparison between signed and unsigned
>
> This regressed around 9/4.
>
> I initially fixed a bunch of signed/unsigned warnings in loop.c on
> 8/15 with casts at each usage of LOOP_REGNO_NREGS. But in hindsight
> that's fragile because one has to remember to put in these casts with
> new uses of the macro. That didn't happen with the 9/4 change so
> instead I propose reverting my 8/15 warning cleanup and instead put
> the cast inside the macro itself.
>
> Tested on mips-irix6.5 and sparc-sun-solaris2.7.
>
> Ok to install?
>
> Thanks,
> --Kaveh
>
>
> 2002-10-09 Kaveh R. Ghazi <ghazi@caip.rutgers.edu>
>
> * loop.c: Revert 2002-08-15 change.
> (LOOP_REGNO_NREGS): Ensure type is int.
This is OK.
--
- Geoffrey Keating <geoffk@geoffk.org>