This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: splay tree gty work
- From: Geoff Keating <geoffk at geoffk dot org>
- To: Mike Stump <mrs at apple dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: 02 Oct 2002 17:35:42 -0700
- Subject: Re: splay tree gty work
- References: <E55B602B-D631-11D6-96D2-000393941EE6@apple.com>
Mike Stump <mrs@apple.com> writes:
> I've ported the patch you sent me from the pch-branch for the splay
> tree GC work to the top of the tree. It fell in effortlessly, most of
> the work was already in, making this fairly easy. I didn't include
> the alpha change below, as I don't have a good way to test that part
> of the change, aside from that, this is the balance of the work, plus
> one bug fix to gengtype.c, and one bug fix to ggc_splay_alloc.
>
> I have completed a test on i586-pc-linux-gnu, should this go into
> mainline or bib?
This isn't a bug-fix (at least, not to the code currently in
mainline), so it should go on the basic-improvements branch unless
it's required for some other bug-fix.
I'll put your changes onto pch-branch too; they are OK. I see that
sibcalls now ensures that bugs like the ggc_splay_alloc one will never
cause visible problems :-(.
> 2002-10-01 Mike Stump <mrs.apple.com>
>
> * ggc-common.c (ggc_splay_alloc): Actually return the allocated area.
> * gengtype.c (write_gc_structure_fields): Handle param[digit]_is.
>
> 2002-10-01 Geoffrey Keating <geoffk@apple.com>
>
> The following changes are merged from pch-branch:
>
> * ggc-common.c (ggc_splay_alloc): New.
> (ggc_splay_dont_free): New.
> * splay-tree.h (GTY): Define if undefined.
> (splay_tree_allocate_fn): Return PTR for compatibility, not void *.
> (struct splay_tree_node_s): Support gengtype.
> (struct splay_tree_s): Likewise. Make allocate_data a PTR,
> not a void *.
> * ggc.h (splay_tree_new_ggc): New.
> (ggc_splay_alloc): Declare.
> (ggc_splay_dont_free): Declare.
> * dwarf2asm.c: Include gt-dwarf2asm.h.
> (mark_indirect_pool_entry): Delete.
> (mark_indirect_pool): Delete.
> (indirect_pool): Use gengtype to mark.
> (dw2_force_const_mem): Don't use ggc_add_root.
> * Makefile.in (dwarf2asm.o): Depend on gt-dwarf2asm.h.
> (GTFILES): Add SPLAY_TREE_H, dwarf2asm.c.
> (gt-dwarf2asm.h): Depend on s-gtype.
--
- Geoffrey Keating <geoffk@geoffk.org>