This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PATCH: make warnings more reasonable for aggregate classes
- From: Dale Johannesen <dalej at apple dot com>
- To: David Edelsohn <dje at watson dot ibm dot com>
- Cc: Dale Johannesen <dalej at apple dot com>, Matt Austern <austern at apple dot com>, gcc-patches at gcc dot gnu dot org
- Date: Wed, 2 Oct 2002 12:45:11 -0700
- Subject: Re: PATCH: make warnings more reasonable for aggregate classes
On Wednesday, October 2, 2002, at 12:37 PM, David Edelsohn wrote:
The GCC coding style places logical operators related to
continuation lines on those new lines.
if (! TYPE_HAS_CONSTRUCTOR (t) && CLASSTYPE_NON_AGGREGATE (t)
&& extra_warnings)
NOT
if (! TYPE_HAS_CONSTRUCTOR (t) && CLASSTYPE_NON_AGGREGATE (t) &&
extra_warnings)
This is the opposite of some Apple coding standard, I presume.
Not that I know of, but the GNU code is the only place I've
seen the operator put on the new line, so it's a natural
mistake. My fingers automatically type it matt's way,
although I usually catch it before submission nowadays.