This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix broken 'make install-po'. Fixes PR other/7727
- From: Josh Martin <Josh dot Martin at abq dot sc dot philips dot com>
- To: aoliva at redhat dot com
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Wed, 11 Sep 2002 22:22:02 -0600 (MDT)
- Subject: Re: [PATCH] Fix broken 'make install-po'. Fixes PR other/7727
- Reply-to: Josh Martin <Josh dot Martin at abq dot sc dot philips dot com>
> On Sep 11, 2002, Josh Martin <Josh.Martin@abq.sc.philips.com> wrote:
>
> > FYI, while I agree that this would be the preferred idiom, as far as
> > the gcc/Makefile.in file is concerned what I used was far more
> > common, which is why I chose it. I would suggest that one single
> > method should be chosen, and then used throughout the file. If you
> > like I could do this and submit a patch.
>
> Sounds good to me. Thanks for volunteering.
>
> Just beware quoting issues. Should $(CATALOGS) or any such variable
> expand to text containing shell active characters, such as backquotes
> or variable substitutions, or even plain quoting characters, you may
> have to change the idiom slightly to make sure you don't run into
> quoting problems.
Correct me if I'm wrong, but won't the idiom you described be resistant to
quoting problems? I thought quoting with 's was non-expanding.
- Josh Martin