This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] New fp register predicates for i386.md
- From: Richard Henderson <rth at redhat dot com>
- To: Roger Sayle <roger at eyesopen dot com>
- Cc: gcc-patches at gcc dot gnu dot org, Andreas Jaeger <aj at suse dot de>
- Date: Wed, 11 Sep 2002 16:56:44 -0700
- Subject: Re: [PATCH] New fp register predicates for i386.md
- References: <Pine.LNX.4.33.0209101502040.25078-100000@www.eyesopen.com>
On Tue, Sep 10, 2002 at 03:21:57PM -0600, Roger Sayle wrote:
> + any_fp_register_operand (op, mode)
> + rtx op;
> + enum machine_mode mode ATTRIBUTE_UNUSED;
> + {
> + return ANY_FP_REG_P (op);
Note the correspondence between "any" in the names here.
> (define_split
> [(set (match_operand:SF 0 "push_operand" "")
> - (match_operand:SF 1 "register_operand" ""))]
> - "!TARGET_64BIT && ANY_FP_REGNO_P (REGNO (operands[1]))"
> + (match_operand:SF 1 "fp_register_operand" ""))]
> + "!TARGET_64BIT"
Which means this change is incorrect, since the replacement
predicate does not use the "any" form.
There are several other such in my brief scan of the first
few hunks. I didn't bother to look at the rest of the patch.
r~