This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [v3] Use __uselocale in codecvt


On Tue, Sep 10, 2002 at 09:39:32PM +0200, Paolo Carlini wrote:
> Hi,
> 
> this fixes two more instances of missing __uselocale (some 
> infrastructure had
> to be added in order to do that). Approved by Benjamin.

Just wondering, doesn't this patch break the ABI?

--- libstdc++-v3/include/bits/codecvt.h    2001-11-02 18:38:10.000000000 +0100
+++ libstdc++-v3/include/bits/codecvt.h 2002-09-10 20:06:44.000000000 +0200
@@ -70,7 +70,11 @@
       typedef _InternT                                         intern_type;
       typedef _ExternT                                         extern_type;
       typedef _StateT                                          state_type;
-
+
+    protected:
+      __c_locale               _M_c_locale_codecvt;
+
+    public:
       // 22.2.1.5.1 codecvt members
       result
       out(state_type& __state, const intern_type* __from,

It certainly changes layout of ctype and ctype_byname templates and e.g.
ctype_byname constructor can be inlined into user code too...

	Jakub


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]