This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PowerPC64 Linux sym visibility fixes
On Sat, Sep 07, 2002 at 08:58:13PM -0700, Richard Henderson wrote:
> On Fri, Sep 06, 2002 at 12:34:52PM +0930, Alan Modra wrote:
> > +#ifndef TARGET_ASM_ASSEMBLE_VISIBILITY
> > +#define TARGET_ASM_ASSEMBLE_VISIBILITY assemble_visibility
> > +#endif
>
> Please rename this to default_assemble_visibility, just
> so no one gets the idea they can call it directly.
I've applied the following
* varasm.c (default_assemble_visibility): Rename from
assemble_visibility.
* output.h: Here too.
* target-def.h (TARGET_ASM_ASSEMBLE_VISIBILITY): And here.
* config/rs6000/rs6000.c (rs6000_assemble_visibility): And here.
Index: gcc/varasm.c
===================================================================
RCS file: /cvs/gcc/gcc/gcc/varasm.c,v
retrieving revision 1.308
diff -u -p -r1.308 varasm.c
--- gcc/varasm.c 8 Sep 2002 04:08:11 -0000 1.308
+++ gcc/varasm.c 8 Sep 2002 09:22:36 -0000
@@ -4597,7 +4597,7 @@ assemble_alias (decl, target)
VISIBILITY_TYPE. */
void
-assemble_visibility (decl, visibility_type)
+default_assemble_visibility (decl, visibility_type)
tree decl;
const char *visibility_type ATTRIBUTE_UNUSED;
{
Index: gcc/output.h
===================================================================
RCS file: /cvs/gcc/gcc/gcc/output.h,v
retrieving revision 1.110
diff -u -p -r1.110 output.h
--- gcc/output.h 4 Sep 2002 01:56:12 -0000 1.110
+++ gcc/output.h 8 Sep 2002 09:22:36 -0000
@@ -258,7 +258,7 @@ extern void assemble_constant_align PARA
extern void assemble_alias PARAMS ((tree, tree));
-extern void assemble_visibility PARAMS ((tree, const char *));
+extern void default_assemble_visibility PARAMS ((tree, const char *));
/* Output a string of literal assembler code
for an `asm' keyword used between functions. */
Index: gcc/target-def.h
===================================================================
RCS file: /cvs/gcc/gcc/gcc/target-def.h,v
retrieving revision 1.32
diff -u -p -r1.32 target-def.h
--- gcc/target-def.h 7 Sep 2002 00:19:26 -0000 1.32
+++ gcc/target-def.h 8 Sep 2002 09:22:36 -0000
@@ -59,7 +59,7 @@ Foundation, 59 Temple Place - Suite 330,
#endif
#ifndef TARGET_ASM_ASSEMBLE_VISIBILITY
-#define TARGET_ASM_ASSEMBLE_VISIBILITY assemble_visibility
+#define TARGET_ASM_ASSEMBLE_VISIBILITY default_assemble_visibility
#endif
#define TARGET_ASM_FUNCTION_PROLOGUE default_function_pro_epilogue
Index: gcc/config/rs6000/rs6000.c
===================================================================
RCS file: /cvs/gcc/gcc/gcc/config/rs6000/rs6000.c,v
retrieving revision 1.371
diff -u -p -r1.371 rs6000.c
--- gcc/config/rs6000/rs6000.c 7 Sep 2002 00:19:27 -0000 1.371
+++ gcc/config/rs6000/rs6000.c 8 Sep 2002 09:22:46 -0000
@@ -8168,7 +8168,7 @@ rs6000_assemble_visibility (decl, visibi
tree decl;
const char *visibility_type;
{
- assemble_visibility (decl, visibility_type);
+ default_assemble_visibility (decl, visibility_type);
/* Functions need to have their entry point symbol visibility set as
well as their descriptor symbol visibility. */
--
Alan Modra
IBM OzLabs - Linux Technology Centre