This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

PATCH to fold in convert_ieee_real_to_integer


Per Bothner writes:
 > While looking into how constant fields propagate, I found that
 > convert_ieee_real_to_integer doesn't constant-fold.  I think it
 > should.  Andrew, I believe this is your code, so please take a
 > look.  You might also want to re-format.  Normally, we do fold
 > fold (build (...)) rather than build (...., fold (...)), so I
 > should move the fold calls (pysically, not logically).

I think this was deliberate, because at the time fold() wasn't doing
the Right Thing with respect to Java.  However, this was a very long
time ago and it's perfectly possible that my memory is inaccurate.

 > (I haven't run the test-suite yet, because libstc++ doesn't build
 > for me.  I'll do that before a check-in.)

I thought I wrote a testcase for this, but I can't find it.  I can't
imagine that I wrote all this stuff without testing it!

Andrew.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]