This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] IA-32 bitfields (was Re: libgcc_s, Linux, and PT_GNU_EH_FRAME, and binutils)


On Tue, Aug 06, 2002 at 03:23:39PM -0700, Mark Mitchell wrote:
> I think this patch is very good, in a technical sense.

Reading the patch again, there might be some problem still lurking
with input like:

struct A
{
  char a;
  long long b : 61 __attribute__((aligned (4)));
  char c;
};

As I misused ADJUST_FIELD_ALIGN instead of
creating new ADJUST_FIELD_TYPE_ALIGN or something, ADJUST_FIELD_ALIGN
will see in this case that DECL_USER_ALIGN is set on the field and bail out,
thus b will be 64-bit aligned.
Now, the question is, should all this PCC_BITFIELD_TYPE_MATTERS and
BITFIELD_NBYTES_LIMITED handling be skipped if DECL_USER_ALIGN is set?

	Jakub


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]