This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] Fix libsupc++/Makefile.in


Neil Booth <neil@daikokuya.co.uk> writes:

| Gabriel Dos Reis wrote:-
| 
| > Neil Booth <neil@daikokuya.co.uk> writes:
| > 
| > | B. Kosnik wrote:-
| > | 
| > | > This patch is conceptually fine, but what you need to do is edit
| > | > libsupc++/Makefile.am and then auto-generate libsupc++/Makefile.in.
| > | > 
| > | > (The best way to do that is, at the top level of libstdc++-v3:
| > | > aclocal; autoconf; autoheader; automake)
| > | 
| > | Ah yes.  Is there a specific version of autoconf etc. I should be
| > | using?  I have 2.13 and 2.50 of autoconf.
| > 
| > I think we are using 2.13 -- my base system comes with 2.52 but I
| > installed 2.13 just for V3 development.
| 
| OK, I'll use 2.13.  I also have automake 1.5 only; it seems the old files
| are made by 1.4p-5 which I don't have.

Ah, I forgot to mention that.  Yes, I think any version of the 1.4
release series should be fine.  I didn't test with 1.5 though.

|  This scares me a little as the
| differences between the new and the old files are *huge*.  The following
| have all changed:
| 
| M Makefile.in
| M aclocal.m4
| M config.h.in
| M configure
| M include/Makefile.in
| M libio/Makefile.in
| M libmath/Makefile.in
| M libsupc++/Makefile.am
| M libsupc++/Makefile.in
| M po/Makefile.in
| M src/Makefile.in
| M testsuite/Makefile.in

As a rule (which has been annoying me), automake tends to touch
(recursively) any Makefile.in it finds.  What I usually do is to
locate the Makefile.in I know should be regenerated and remove others
that should not have been touched.  

But I suspect just committing all them should be fine.

Actually, if you look at the difference, you'll notice that it is mostly
about *formatting* (i.e. newlines replaced with spaces or vice versa).
Ugh. 

| If you're happy, I'll go ahead and commit it, otherwise I'd appreciate
| it if someone else could do it for me.

Benjamin?

-- Gaby


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]