This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix 3.1 ICE on mplayer (regression from egcs 1.1.2 at least)


On Wed, Jul 10, 2002 at 05:01:09PM +0200, Jakub Jelinek wrote:
> BTW: I wonder whether const_int_1_operand shouldn't be killed and replaced
> by const1_operand, any CONST_INT with INTVAL() == 1 should
> be const1_rtx, shouldn't it?

Correct.  I don't care one way or the other about renaming
the function.

> 	PR middle-end/7245
> 	* config/i386/i386.c (const_int_1_31_operand): New.
> 	* config/i386/i386.h (PREDICATE_CODES): Add it.
> 	* config/i386/i386.md (ashlsi3_cmp, ashlsi3_cmp_zext, ashlhi3_cmp,
> 	ashlqi3_cmp, ashrsi3_cmp, ashrsi3_cmp_zext, ashrhi3_cmp, ashrqi3_cmp,
> 	lshrsi3_cmp, lshrsi3_cmp_zext, lshrhi3_cmp, lshrqi3_cmp): Use it.
> 
> 	* gcc.c-torture/compile/20020710-1.c: New test.

Ok.

Need Mark for branch approval, but since it's a regression
I wouldn't expect him to disapprove.


r~


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]