This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Overhaul builtin function attributes
- From: Roger Sayle <roger at eyesopen dot com>
- To: "Joseph S. Myers" <jsm28 at cam dot ac dot uk>
- Cc: <gcc-patches at gcc dot gnu dot org>
- Date: Thu, 4 Jul 2002 11:08:31 -0600 (MDT)
- Subject: Re: [PATCH] Overhaul builtin function attributes
On Thu, 4 Jul 2002, Joseph S. Myers wrote:
> On Thu, 4 Jul 2002, Roger Sayle wrote:
> I don't think the patch should be adding a blank line at end of file.
Sorry. the remnants of an earlier revision of this patch. I
decided that rather than add new attributes to the end of the
file, I'd preserve your original ATTR_NULL, the integers, then
identifiers, then lists ordering of definitions.
> > /* Handle C and C++ default attributes. */
> > -
> > - enum built_in_attribute
>
> This comment should move along with the declarations it appears above.
Personally, I think its better to keep the comment with the
code that actually handles C and C++ default attributes. Only
the definition of the enumerated type "built_in_attribute" and
some forward prototypes were moved earlier. And the comment
already above the new location seemed appropriate.
What do you think?
Roger
--