This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Xtensa: fix up a comment


This patch corrects a typo ("memory" instead of "registers") in a comment and updates the comment overall to reflect the fact that the Xtensa calling convention is now essentially fixed. Committed on the mainline.

2002-06-28 Bob Wilson <bob.wilson@acm.org>

* config/xtensa/xtensa.h (RETURN_IN_MEMORY): Update comment.


Index: xtensa.h
===================================================================
RCS file: /cvs/gcc/gcc/gcc/config/xtensa/xtensa.h,v
retrieving revision 1.15
diff -c -r1.15 xtensa.h
*** xtensa.h	27 Jun 2002 04:33:41 -0000	1.15
--- xtensa.h	28 Jun 2002 17:22:15 -0000
***************
*** 796,808 ****
  /* Don't worry about compatibility with PCC.  */
  #define DEFAULT_PCC_STRUCT_RETURN 0
  
! /* For Xtensa, we would like to be able to return up to 6 words in
!    memory but GCC cannot support that.  The return value must be given
!    one of the standard MODE_INT modes, and there is no 6 word mode.
!    Instead, if we try to return a 6 word structure, GCC selects the
!    next biggest mode (OImode, 8 words) and then the register allocator
!    fails because there is no 8-register group beginning with a10.  So
!    we have to fall back on the next largest size which is 4 words... */
  #define RETURN_IN_MEMORY(TYPE)						\
    ((unsigned HOST_WIDE_INT) int_size_in_bytes (TYPE) > 4 * UNITS_PER_WORD)
  
--- 796,808 ----
  /* Don't worry about compatibility with PCC.  */
  #define DEFAULT_PCC_STRUCT_RETURN 0
  
! /* For Xtensa, up to 4 words can be returned in registers.  (It would
!    have been nice to allow up to 6 words in registers but GCC cannot
!    support that.  The return value must be given one of the standard
!    MODE_INT modes, and there is no 6 word mode.  Instead, if we try to
!    return a 6 word structure, GCC selects the next biggest mode
!    (OImode, 8 words) and then the register allocator fails because
!    there is no 8-register group beginning with a10.)  */
  #define RETURN_IN_MEMORY(TYPE)						\
    ((unsigned HOST_WIDE_INT) int_size_in_bytes (TYPE) > 4 * UNITS_PER_WORD)
  

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]