This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: patch: cleanup PPC builtins
- From: David Edelsohn <dje at watson dot ibm dot com>
- To: Aldy Hernandez <aldyh at redhat dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Fri, 28 Jun 2002 13:21:33 -0400
- Subject: Re: patch: cleanup PPC builtins
2002-06-27 Aldy Hernandez <aldyh@redhat.com>
* config/rs6000/rs6000.c (altivec_expand_builtin): Move
lvx/stv/dst builtins...
(altivec_expand_ld_builtin): ...to here.
(altivec_expand_st_builtin): ...here.
(altivec_expand_dst_builtin): ...and here (respectively).
This is fine, but please add comments -- even trivial -- before the new
functions. It can be confusing to someone reading the code that the
documentation doesn't come until after most of the functions, although it
is reasonable to define the sub-functions before they are used.
Thanks, David