Re: [patch] ppc SUBTARGET_OVERRIDE_OPTIONS

[Geoff Keating <geoffk at geoffk dot org>]

> Date: Fri, 28 Jun 2002 08:55:36 -0700
> From: Aldy Hernandez <aldyh@redhat.com>
> Cc: gcc-patches@gcc.gnu.org
> Content-Disposition: inline
> User-Agent: Mutt/1.3.25i
> X-OriginalArrivalTime: 28 Jun 2002 15:55:37.0718 (UTC) FILETIME=[3EDD7160:01C21EBC]
> 
> 
> > Not OK.  The whole point of those macros is that they go after, so
> > that a "subtarget" can "override options".
> 
> so then if a target sets rs6000_altivec_abi, like darwin does,
> then there's absolutely no way to disable it with user options?  the
> compiler will completely (and silently) ignore the user options.  this
> doesn't sound very good.

You should read the next paragraph I wrote, which explains how you can
fix this problem:

> > If you want to set a default, create a macro like TARGET_DEFAULT.
> 
> yeah, but we can't do that with either -mabi or -mvrsave because we've
> run out of bits.  TARGET_DEFAULT is a mask of target_flags.  both
> -mabi and -mvrsave have a separate variable.
> 
> [perhaps i should get around to doing the massive target stuff rewrite
> we have talked about to free target bits]

So, create a new macro to initialise the separate variable.  That's
why I said "create a macro like TARGET_DEFAULT" not "change the
definition of TARGET_DEFAULT".

-- 
- Geoffrey Keating <geoffk@geoffk.org> <geoffk@redhat.com>