This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] ppc SUBTARGET_OVERRIDE_OPTIONS


Aldy Hernandez <aldyh@redhat.com> writes:

> hi david.
> 
> i'd like to move *SUBTARGET_OVERRIDE_OPTIONS before we handle user
> options such as -mdebug-, -mlong-double-, -mabi=, -mvrsave=, etc.
> 
> as it stands now, if a target sets say:
> 
>   #define SUBTARGET_OVERRIDE_OPTIONS rs6000_altivec_abi = 1
> 
> there is no way to unset it with -mabi=no-altivec, because 
> *SUBTARGET_OVERRIDE_OPTIONS comes after.
> 
> same thing goes for vrsave, long-double, and -mdebug settings.  if
> your target sets SUBTARGET_OVERRIDE_OPTIONS to twiddle the settings,
> you can't undo the change with user options.

Not OK.  The whole point of those macros is that they go after, so
that a "subtarget" can "override options".

If you want to set a default, create a macro like TARGET_DEFAULT.

If you've already committed it, please back it out.

> ok?
> 
> 2002-06-27  Aldy Hernandez  <aldyh@redhat.com>
> 
> 	* rs6000.c (rs6000_override_options): Move
> 	*SUBTARGET_OVERRIDE_OPTIONS before the -m options.

-- 
- Geoffrey Keating <geoffk@geoffk.org> <geoffk@redhat.com>


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]