This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: ip2k port reviewing/accepting
- From: Denis Chertykov <denisc at overta dot ru>
- To: Geoff Keating <geoffk at geoffk dot org>
- Cc: Denis Chertykov <denisc at overta dot ru>, gcc-patches at gcc dot gnu dot org
- Date: 20 Jun 2002 01:10:13 +0400
- Subject: Re: ip2k port reviewing/accepting
- References: <auto-000002653214@overta.ru> <jmn0trm1zn.fsf@desire.geoffk.org>
Geoff Keating <geoffk@geoffk.org> writes:
>
> It seems generally OK, but:
>
> - It needs a ChangeLog entry
I send it separate.
> - You need to update the documentation, in particular the constraints
> need to be documented
Will be sended shortly.
IMHO: better to have a separate patch for documentation.
(Do not mix them with config/ip2k/* files).
Must I got approval for committing patch for documentation ?
> - In cases like this:
>
> #if 0 /* FIXME: denisc@overta.ru */
[...]
>
> There are some minor things that you might consider doing now or after
> the port is committed:
I prefer to have a ChangeLog entries for all such changes.
> - change all occurrences of "gen_rtx (XXX, " into "gen_rtx_XXX (" for
> all 'XXX', for instance in INIT_TARGET_OPTABS. There are many
> instances, be sure to get them all.
Will be done.
Can I commit port now ?
Denis.