This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Use C for some rs6000 -D options.


Aldy Hernandez <aldyh@redhat.com> writes:

> >>>>> "Geoffrey" == Geoffrey Keating <geoffk@romulus.sfbay.redhat.com> writes:
>  > +#define builtin_define(TXT) cpp_define (pfile, TXT)
>  > +#define builtin_assert(TXT) cpp_assert (pfile, TXT)
> 
> wouldn't it be better to name these:
> 
> 	builtin_cpp_define
> 	builtin_cpp_assert
> 
> ..to avoid confusion with builtins?

They're copy-and-pasted from c-common.c.  I thought it would be better
to keep the same name.

-- 
- Geoffrey Keating <geoffk@geoffk.org> <geoffk@redhat.com>


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]