This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: It's (PCH) merging time!
> Careful inspection of the source that used libiberty indicated that no
> code was using the removed functions.
bfd uses htab_create(). Since bfd and libiberty are often built and
installed as shared libraries (whether we support that or not),
changing a function from a real entry point to a #define may cause
problems. It's OK to *add* a #define to speed up the code, but not OK
to remove a real function from libiberty.a.
> > Could you please revert these
> > changes until such time as the patch can actually be reviewed?
>
> The whole PCH merge patch, all 30k lines of it?
At least the libiberty bits. They affect other projects.
> I'm not sure there's actually time for anyone to review a patch of
> that size before it becomes out-of-date.
I wouldn't consider that to be a valid excuse, though. You, of
course, have the authority to check it in without review.