This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: CPP built-in cleanup for NetBSD SPARC targets


On Wednesday, May 29 2002, "Jason R Thorpe" wrote to "Jonathan Lennox, gcc-patches@gcc.gnu.org" saying:

> On Thu, May 30, 2002 at 12:25:39AM -0400, Jonathan Lennox wrote:
> 
>  > Are the braces really correct on that else clause?  You only define __sparc
>  > for 32-bit SPARC, but you define __sparc__ for all SPARC platforms?
> 
> Yes, this is historical practice in NetBSD.
> 
>  > If this is really what you meant (and it seems surprising), some explicit
>  > braces, and a comment explaining why, would probably be helpful.
> 
> ...the indentation doesn't make it clear enough?

No, I suppose it does; I correctly interpreted what it was doing, I was just
surprised.  A comment about the historical practice would probably be
helpful.

-- 
Jonathan Lennox
lennox@cs.columbia.edu


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]