This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Patch to libobjc/Makefile.in, set SHELL, use -O2 & -W*
> From: Alexandre Oliva <aoliva@redhat.com>
>
> On May 10, 2002, "Kaveh R. Ghazi" <ghazi@caip.rutgers.edu> wrote:
>
> > * Makefile.in (SHELL): Set to @SHELL@.
>
> Ok. Care to make the same change in libf2c/Makefile.in?
> Pre-approved.
I think Toon already did it, but see my other message about
lib*77/Makefile.in.
> > (WARN_CFLAGS): New.
>
> Ok
>
> > (ALL_CFLAGS): Add -O2 $(WARN_CFLAGS).
>
> I wonder if we wouldn't be better off adding -O2 to CFLAGS_FOR_TARGET
> in the top level... Then, users could still override this relatively
> easily.
Ok I omitted the -O2 part until we figure out where to add it. Here's
what I installed.
Thanks,
--Kaveh
Index: ChangeLog
===================================================================
RCS file: /cvs/gcc/gcc/libobjc/ChangeLog,v
retrieving revision 1.76
diff -u -p -r1.76 ChangeLog
--- ChangeLog 16 May 2002 17:42:57 -0000 1.76
+++ ChangeLog 20 May 2002 16:33:44 -0000
@@ -1,3 +1,9 @@
+2002-05-20 Kaveh R. Ghazi <ghazi@caip.rutgers.edu>
+
+ * Makefile.in (SHELL): Set to @SHELL@.
+ (WARN_CFLAGS): New.
+ (ALL_CFLAGS): Add $(WARN_CFLAGS).
+
2002-05-16 Rainer Orth <ro@TechFak.Uni-Bielefeld.DE>
* aclocal.m4: Allow for PWDCMD to override hardcoded pwd.
Index: Makefile.in
===================================================================
RCS file: /cvs/gcc/gcc/libobjc/Makefile.in,v
retrieving revision 1.20
diff -u -p -r1.20 Makefile.in
--- Makefile.in 11 Feb 2002 18:10:05 -0000 1.20
+++ Makefile.in 20 May 2002 16:33:44 -0000
@@ -22,7 +22,7 @@
#Makefile.in files. Some of this stuff may be unnecessary and
#worthless.
-SHELL = /bin/sh
+SHELL = @SHELL@
MAKEOVERRIDES=
#### Start of system configuration section. ####
@@ -67,8 +67,9 @@ RANLIB = @RANLIB@
CC = @CC@
CFLAGS = @CFLAGS@
+WARN_CFLAGS = -W -Wall -Wwrite-strings -Wstrict-prototypes
GTHREAD_FLAGS=@GTHREAD_FLAGS@
-ALL_CFLAGS = -I. -I$(srcdir) $(CPPFLAGS) $(DEFS) $(CFLAGS) \
+ALL_CFLAGS = -I. -I$(srcdir) $(CPPFLAGS) $(DEFS) $(CFLAGS) $(WARN_CFLAGS) \
$(GTHREAD_FLAGS) -DIN_GCC -DIN_TARGET_LIBS
# Libtool