This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Patch: libstdc++-v3 irix6.2 fix for 70 broken g++ testsuite results


 > From: Mark Mitchell <mark@codesourcery.com>
 > 
 > > +/* On at least irix6.2 (which uses this file,) the header files are
 > > +   very fragile and depend heavily on _SGI_SOURCE and __EXTENSIONS__
 > > +   being defined.  If they're not, then features disappear that
 > > +   configure was relying on which then breaks the libstdc++ headers.
 > > +   These macros are normally implicitly defined by the command-line,
 > > +   however they are not defined when -ansi is used, and -ansi is
 > > +   passed to the testsuite.  The g++ test results (where it uses
 > > +   libstdc++ headers) get dozens of extra failures without these
 > > +   macros, so ensure they always are defined here.  */
 > 
 > This isn't how we've "solved" this elsewhere, I think.
 > 
 > Instead, what we've done is to make -ansi turn on things like _SGI_SOURCE
 > anyhow, in C++.
 > 
 > Neither solution is correct; the -ansi change makes -ansi mean something
 > different than what it should, while the change you propose won't work
 > if people include the OS headers before the V3 headers.  We could argue
 > all day about which breakage is worse, but we might as well use the same
 > breakage everywhere.

If you prefer, I can try converting the irix5.2/6.2 port to be
consistent in this respect.  But I'm not sure where to do it, can you
point me at the spot in the code where another port does it the "right
way"?

		--Kaveh
--
Kaveh R. Ghazi			Director of Systems Architecture
ghazi@caip.rutgers.edu		Qwest Global Services


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]