This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Patch: libstdc++-v3 ctype 8-bit safety for irix through irix6.4
> From: Mark Mitchell <mark@codesourcery.com>
>
> > I'd like to install it on the trunk and 3.1 branch also. Ok?
>
> Explain why this is a good thing. :-)
As noted here http://gcc.gnu.org/ml/libstdc++/2002-03/msg00146.html
"The current version of ctype<char> doesn't work for chars with the
8th bit set, in implementations where char is signed."
Now I hear you saying, "but irix6 has unsigned char by default!!" :-)
Yes, the bug will only be exposed when using -fsigned-char.
E.g. the test03 function in 22_locale/ctype_members_char.cc fails
when using -fsigned-char.
Admittedly its an obscure bug unlikely to be encountered :-) but the
fix is similarly limited given that it only touches platforms using
the irix5.2 config dir.
> Does it fix regressions?
Ah no, the bug has probably always been there. Drated commit rules! :-)
So if you reject it for 3.1, how about for 3.1.1 then?
--Kaveh
--
Kaveh R. Ghazi Director of Systems Architecture
ghazi@caip.rutgers.edu Qwest Global Services